Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes should not load jQuery if it's available #2062

Closed
ralsina opened this issue Sep 11, 2015 · 3 comments
Closed

Themes should not load jQuery if it's available #2062

ralsina opened this issue Sep 11, 2015 · 3 comments
Labels
enhancement
Milestone
Whenever

Comments

@ralsina
Copy link
Member

ralsina commented Sep 11, 2015

Currently, JQuery is loaded unconditionally in base. This means that if I change templates for a single page, and want to use jQuery in it, it will break in mysterious ways once it's reloaded.
@ralsina ralsina added the bug label Sep 11, 2015
@ralsina ralsina added this to the 7.7.1 milestone Sep 11, 2015
@ralsina ralsina added enhancement and removed bug labels Sep 13, 2015
@ralsina ralsina modified the milestones: 7.7.1, 7.7.2 Sep 15, 2015
@Kwpolska Kwpolska modified the milestones: v7.7.2, v7.7.3 Oct 8, 2015
@Kwpolska Kwpolska modified the milestones: v7.7.3, v7.7.4 Oct 30, 2015
@ralsina ralsina modified the milestones: v7.7.4, v7.7.5 Dec 21, 2015
@Kwpolska
Copy link
Member

Are you sure it’s loaded? Would you mind double-checking and clarifying?

@Kwpolska Kwpolska modified the milestones: v7.7.5, v7.7.6 Feb 11, 2016
@ralsina
Copy link
Member Author

ralsina commented Feb 11, 2016

The problem is adding a <script> in <head> that loads JQuery. So yes, that loads it and it's loaded. Then it's loaded again by other parts of the template and things break.

@ralsina ralsina modified the milestones: v7.7.6, v7.7.7 Feb 17, 2016
@ralsina ralsina modified the milestones: v7.7.7, v7.7.8 Mar 10, 2016
@Kwpolska Kwpolska modified the milestones: v7.7.8, v7.7.9 Apr 29, 2016
@Kwpolska Kwpolska modified the milestones: v7.7.9, v7.8.0 Jun 11, 2016
@ralsina ralsina modified the milestones: v7.7.10, 7.7.11 Jul 20, 2016
@Kwpolska Kwpolska modified the milestones: v7.7.12, v7.7.13 Aug 5, 2016
@ralsina ralsina modified the milestones: v7.7.13, Whenever Aug 18, 2016
@ralsina
Copy link
Member Author

ralsina commented Jun 26, 2017

Since now base doesn't load JQuery anymore, no worries, closing.

@ralsina ralsina closed this as completed Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Whenever
Development

No branches or pull requests
2 participants
@ralsina @Kwpolska