Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikola exposes posts in sitemap that are in the future #3339

Closed
kayhayen opened this issue Jan 6, 2020 · 1 comment
Closed

Nikola exposes posts in sitemap that are in the future #3339

kayhayen opened this issue Jan 6, 2020 · 1 comment
Assignees
Labels

Comments

@kayhayen
Copy link
Contributor

kayhayen commented Jan 6, 2020

Environment

Python Version:

3.7

Nikola Version:

Latest PyPI

Operating System:

Linux

Description:

The Google search console just alerted me of 404 errors. There is a release announcement post, that I schedule a day in the future, when I generate the pages, so I got time to get the packaging sorted out until then. I think, in the past, the page became a draft and was uploaded. I might have remove the draft tag myself, assuming the date works the same.

http://nuitka.net/sitemap.xml
http://nuitka.net/sitemapindex.xml

However, it surely is a bug to expose the URL of a non-existing post. I have seen issues in the past that this has happened with pretty URLs and with actual drafts. Maybe the future date is different?

You can see my environment here: https://github.com/Nuitka/Nuitka-website but I strongly doubt that it's relevant. Also the issue of future post will be gone within the hour. I just wanted to mention this issue to you, I don't see much severity personally, as the URL contains no secrets.

Yours,
Kay

Yours,
Kay

@kayhayen kayhayen added the bug label Jan 6, 2020
@Kwpolska Kwpolska self-assigned this Feb 5, 2020
@Kwpolska
Copy link
Member

Kwpolska commented Feb 5, 2020

Sorry this took a month to look into. This was a very small oversight in an alternate code path that doesn’t get triggered with PRETTY_URLS = True (and our tests only did that one). I fixed that on master, and also added a test for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants