Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotation_helper.tmpl includes jquery via HTTP, includes no longer existing assets.annotateit.org #3764

Closed
felixfontein opened this issue Mar 2, 2024 · 0 comments · Fixed by #3765
Closed

annotation_helper.tmpl includes jquery via HTTP, includes no longer existing assets.annotateit.org #3764

felixfontein opened this issue Mar 2, 2024 · 0 comments · Fixed by #3765
Labels
bug

Comments

@felixfontein
Copy link
Contributor

annotation_helper.tmpl references two resources via HTTP on assets.annotateit.org, which no longer exists, and includes jquery via HTTP as well (which should be changed to HTTPS).

On the other hand, it seems that annotation_helper.tmpl is no longer really used; it's still included in some theme, but not used at all. 8dc03e1 removed notes.css(), and before that, 4dff674 removed most of annotation support.

So I guess this is just a leftover.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove more leftovers from annotateit.org getnikola/nikola
1 participant
@felixfontein