New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour patch row based on check status #198
Comments
Thoughts on the way that patchwork.freedesktop.org handles it? https://patchwork.freedesktop.org/project/intel-gfx/series/?ordering=-last_updated I would personally only want the coloured background behind the S/W/F part |
Good idea but like @ruscur I think colouring the whole row might be a bit much, very visually noisy. I like the look of pw.fdo (though it annoys me that their s/w/f blocks aren't of equal width) |
Maybe red for 0 in A/R/T too, to provide extra incentive for maintainers to not merge unreviewed code? |
Yep agree the FDO UI is nicer than my idea. Can we just pull in their code? |
I really want this so I might try and do it myself if noone else wants to, note that I know nothing about frontend webdev so making a thing red or green may take several eons |
The colors have been added on check numbers: |
The ability to attach test results to a patch using the check feature is awesome.
However the display of the results in the list view is very subtle. ie. a failed patch and a successfully checked patch differ only by the position of a single digit in the S/W/F column, they're easy to miss.
What would be nice is if the row was coloured based on the status.
So perhaps fail: red, warning: orange, success: white or green.
Green for successful checks would be good, as it would mean you could skip over patches that hadn't been checked yet, but it might make the UI a bit garish.
Here is a terribly gimped screenshot of what I have in mind:
The text was updated successfully, but these errors were encountered: