Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser doesn't work with diffs from git merge commits #284

Open
ajdlinux opened this issue Jul 9, 2019 · 0 comments
Open

parser doesn't work with diffs from git merge commits #284

ajdlinux opened this issue Jul 9, 2019 · 0 comments
Labels

Comments

@ajdlinux
Copy link
Collaborator

ajdlinux commented Jul 9, 2019

@mpe reported that https://patchwork.ozlabs.org/patch/1129056/ is missing a patch diff.

It appears this is because it's a diff of a git merge commit:

diff --cc arch/powerpc/include/asm/pgtable.h
index bf7d771f342e,64145751b2fd..000000000000
--- a/arch/powerpc/include/asm/pgtable.h
+++ b/arch/powerpc/include/asm/pgtable.h
@@@ -140,30 -140,20 +140,44 @@@ static inline void pte_frag_set(mm_cont
  }
  #endif

as opposed to a normal diff

diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c
index 80ceb458e79c..ef75f590ad3e 100644
--- a/arch/powerpc/kernel/module_64.c
+++ b/arch/powerpc/kernel/module_64.c
@@ -133,20 +133,27 @@ struct ppc64_stub_entry
  * the stub, but it's significantly shorter to put these values at the
  * end of the stub code, and patch the stub address (32-bits relative

The part that the parser trips on is the unusual format of the @@@ header line because of diff --cc mode.

This isn't too high priority since sending a merge diff to a mailing list is not the normal case, but we might still want to consider fixing the regex to cope with this.

@stephenfin stephenfin added the bug label Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants