Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pw sometimes fetches same patch in series for two different patch numbers #459

Closed
sc00beyd00 opened this issue Mar 18, 2022 · 7 comments

Comments

@sc00beyd00
Copy link

When running git-pw patch apply on the first URL below it applies ok but the second URL still fetches the first patch.

https://patchwork.yoctoproject.org/project/oe/patch/1647524807-17685-1-git-send-email-xuhuan.fnst@fujitsu.com/

https://patchwork.yoctoproject.org/project/oe/patch/1647524807-17685-2-git-send-email-xuhuan.fnst@fujitsu.com/

Is there a client-side fix or is there something up with Patchwork?

@stephenfin
Copy link
Member

This is expected behaviour in git-pw. It will automatically try to fetch series dependencies (i.e. previous patches in the series? for a patch. You can disable this behaviour with the --no-deps option.

@kraj
Copy link

kraj commented Mar 24, 2022

@stephenfin even with git-pw patch apply <number> -s it will try to fetch series ? If so, thats a bit counter intuitive

@stephenfin
Copy link
Member

What's the -s option? I assume that's a typo?

git-pw patch apply will attempt to apply the dependencies for a patch. The rationale is that you can't apply patch X of Y if you didn't apply X-1, X-2, etc. first. If you don't want this behavior, you can set up an alias in your .bashrc to set --no-deps by default.

@kraj
Copy link

kraj commented Mar 24, 2022

-s is passed to git command underneath, which adds my sign-off-by to patch

@kraj
Copy link

kraj commented Mar 24, 2022

What's the -s option? I assume that's a typo?

git-pw patch apply will attempt to apply the dependencies for a patch. The rationale is that you can't apply patch X of Y if you didn't apply X-1, X-2, etc. first. If you don't want this behavior, you can set up an alias in your .bashrc to set --no-deps by default.

yeah I get it though it did not come naturall, since there is also git-pw series command, so I thought git-pw patch is just to deal with single patches.

@stephenfin
Copy link
Member

-s is passed to git command underneath, which adds my sign-off-by to patch

Oh, of course.

What's the -s option? I assume that's a typo?
git-pw patch apply will attempt to apply the dependencies for a patch. The rationale is that you can't apply patch X of Y if you didn't apply X-1, X-2, etc. first. If you don't want this behavior, you can set up an alias in your .bashrc to set --no-deps by default.

yeah I get it though it did not come naturall, since there is also git-pw series command, so I thought git-pw patch is just to deal with single patches.

Fair. I personally tend to apply individual patches rather than series because we've a gap in series support still (namely the inability to set a series state, which means git pw series list lists all patches ever). As I said, an alias will resolve this. I'll see if I can find some time to add a knob to control this behavior.

@kraj
Copy link

kraj commented Mar 24, 2022

yes now I use

git-pw patch apply --no-deps $1 -s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants