Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable markdown extensions order #2044

Closed
Totktonada opened this issue Nov 3, 2016 · 0 comments
Closed

Unstable markdown extensions order #2044

Totktonada opened this issue Nov 3, 2016 · 0 comments
Milestone

Comments

@Totktonada
Copy link
Contributor

I tested Pelican with #1927 merged and found one breaking difference with Pelican 3.6.3.

In Pelican 3.6.3 extensions is list, which passed to Markdown as is (with 'meta' added) and all extensions initialized in order. Now it can be dictionary extension_configs or list extensions. But in any way it will passed through list(set(settings['extensions'])). So extensions initialized in arbitrary order and a new order for each Pelican execution. Looks like such behaviour starts even before, with #1638.

I have extensions that depend on some internal parsers and ones from 'abbr' and 'meta' extensions. I can add my parser before or after some internal one, but now I cannot add my parser after one from 'meta' or 'abbr'.

I suggest to removing repeated extensions w/o changing its order or don’t do it at all (just carefully add keys from 'extension_configs' to end of 'extension'). The second way looks better for me.

@Scheirle, do you have time to fix it? I can make PR if it’s needed. Hope it should be fixed before 3.7 will released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants