Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme leaves bad impression #2911

Closed
paulfertser opened this issue Aug 8, 2021 · 2 comments
Closed

Default theme leaves bad impression #2911

paulfertser opened this issue Aug 8, 2021 · 2 comments
Labels

Comments

@paulfertser
Copy link

  • [ x] I have read the Filing Issues and subsequent “How to Get Help” sections of the documentation.
  • [ x] I have searched the issues (including closed ones) and believe that this is not a duplicate.
  • Pelican version: 4.6.0
  • Link to theme: notmyidea, integrated

Issue

There're multiple shortcomings about the default theme, especially with narrow screens (such as many mobile devices have):

  1. banner h1 (used for site title) has line-height:0 which results in ugly second line overlaying on top of the first if the text doesn't fit a single line. I got this effect by looking at "Open On-Chip Debug" with JS disabled so that default Chromium on Debian font was used;
  2. banner nav (contains links to pages and categories) has hardcoded height, so if not all links fit the first line the others are shown white-on-white, the background doesn't expand;
  3. many big blocks have ~800px width hardcoded, this results in necessity for horizontal scrolling on narrow displays;
  4. when an Atom feed is enabled there's no way to suppress showing "Social links" block without editing the theme.
    As a sidenote, I'm quite happy with my experience migrating a website from wordpress, everything (but the iframe links to youtube) converted nicely, Pelican documentation is extensive, pretty good overall impression. Other than the problems with the default theme which are hard to solve for somebody who has no clue about web development.
    Please consider making default theme really modern, "mobile-friendly", flexible and compatible with wide range of fonts and other user stylesheet tweaks (such as "dark mode").
@paulfertser paulfertser added the bug label Aug 8, 2021
@justinmayer
Copy link
Member

I agree, and this has been a long-outstanding goal. That said, someone would need to propose and implement a solution that meets that goal, and so far that hasn't happened. If you'd like to assist with that, which would be most welcome, let's discuss that further in the context of the already-existing issue #1280.

@BenSturmfels
Copy link
Contributor

BenSturmfels commented Aug 17, 2021

@paulfertser I've addressed items 1-3 in #2914. If you get a chance, please test it out and let me know if you spot any major issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants