Test content generation with git diff return value #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't show the |
copperchin
force-pushed
the
fix-3042
branch
from
e77f810
to
d4a8aad
Compare
avaris
reviewed
Oct 17, 2022
copperchin
force-pushed
the
fix-3042
branch
2 times, most recently
from
163baf4
to
c31503f
Compare
Assert equal dirs by return value of diff subprocess, rather than its output. This prevents tests from failing when file contents are the same but the file modes are different. Fix getpelican#3042
and minor tweaks to subprocess handling
avaris
approved these changes
Oct 28, 2023
|
FYI, I also added a commit to skip |
justinmayer
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Many thanks to @copperchin for the enhancement and to @avaris for the review and follow-up improvements. 🏅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to parse output of subprocess, just check the return value.
Fix #3042
Pull Request Checklist