Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Substitutions not substituted everywhere #965

Open
bertbesser opened this issue Feb 20, 2021 · 2 comments
Open

CLI: Substitutions not substituted everywhere #965

bertbesser opened this issue Feb 20, 2021 · 2 comments

Comments

@bertbesser
Copy link

bertbesser commented Feb 20, 2021

My goal is to use a substitutions for container labels, like e.g.

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: $_POPPER_SUBST_LABEL
    args: some-args

However, popper does substitutions only within top-level keys of each step (e.g. id) and top-level dicts (e.g. env), but not further down the yaml tree.

Observed behavior

popper run -f the-above-wf.yml --substitution _POPPER_SUBST_LABEL=this-should-appear results in

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: $_POPPER_SUBST_LABEL
    args: some-args

instead of the expected output.

Expected behavior

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: this-should-appear
    args: some-args
@bertbesser
Copy link
Author

For reference, the documentation suggests that substitutions apply globally: link to doc.

Here's a link to the code.

@bertbesser bertbesser changed the title Substitutions not substituted everywhere CLI: Substitutions not substituted everywhere Feb 21, 2021
@bertbesser
Copy link
Author

#967 Solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant