Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve secret source for parameters #14

Closed
vdice opened this issue Jun 9, 2020 · 1 comment
Closed

Resolve secret source for parameters #14

vdice opened this issue Jun 9, 2020 · 1 comment

Comments

@vdice
Copy link
Member

vdice commented Jun 9, 2020

From getporter/porter#1053:

  • Add support for deriving the secret source for applicable parameters (source: secret)
@vdice vdice added this to Inbox in Porter and Mixins [OLD] via automation Jun 9, 2020
@vdice
Copy link
Member Author

vdice commented Jun 9, 2020

🎉 This already just works ™️, thanks to the implementation by @carolynvs ! The existing Azure Keyvault secret resolution code works regardless if the source is for a credential or parameter. (Tested via https://github.com/vdice/porter-bundles/tree/master/azure-keyvault)

@vdice vdice closed this as completed Jun 9, 2020
Porter and Mixins [OLD] automation moved this from Inbox to Done Jun 9, 2020
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant