Update to use Azure SDK modules #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichristensen
requested review from
carolynvs,
simongdavies,
sgettys and
bdegeeter
as code owners
Autorest is legacy, see https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-authorization, for more information. The result is that the custom credentials functions is no longer needed, simplifying the code. A downside is that this custom prefixes are no easily supported, but Microsoft have standardized everything be prefixed with `AZURE_`, and the possibility to changed the prefix was not documented. Signed-off-by: Kim Christensen <kmch@simcorp.com>
kichristensen
force-pushed
the
updateAzureSdk
branch
from
11b6634
to
4f20dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Azure SDK modules as Autorest is legacy, see https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-authorization, for more information.
The result is that the custom credentials functions is no longer needed, simplifying the code.
A downside is that this custom prefixes are no easily supported, but Microsoft have standardized everything be prefixed with
AZURE_, and the possibility to changed the prefix was not documented, so it could be considered okay to remove this functionality, please let me know what you think.Also fixes #35