-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish from archive should use a relocation map #1819
Comments
I see a behavior which may be the same root cause. I have bundles which are airgapped (includes images from docker.io) and this bundle is pushed to my own registry.
|
It very well could be related but I'm not confident. I'll try to reproduce and debug this week, as between this and your previous issue I think I have enough to go on. |
I found the original issue that Vaughn made to track this work: #739 |
Closed by #2186. |
I was reviewing this PR and that we don't use a relocation mapping file and preserve the original bundle.
See this very wonderfully long function comment for context:
porter/pkg/porter/publish.go
Lines 172 to 186 in 784d61c
This PR is correcting a bug in Porter where when we copy a bundle from one registry to another, we aren't preserving the relocation map. I was checking all the code that I thought would use that function and wasn't clear on why we are essentially "re-publishing" the bundle from the archive instead of preserving the original.
Originally posted by @carolynvs in #1815 (comment)
Vaughn confirmed that we should update the implementation of publish from archive to preserve the original bundle and use a relocation mapping file.
The text was updated successfully, but these errors were encountered: