Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable defaulting dependency parameters from the manifest #800

Closed
carolynvs opened this issue Nov 11, 2019 · 1 comment · Fixed by #976
Closed

Re-enable defaulting dependency parameters from the manifest #800

carolynvs opened this issue Nov 11, 2019 · 1 comment · Fixed by #976

Comments

@carolynvs
Copy link
Member

carolynvs commented Nov 11, 2019

We had to turn off defaulting dependency parameters from the manifest temporarily in #799. Once we have a solution for consistently having access to the manifest for both file based and tag based bundle execution, let's turn it back on.

@carolynvs carolynvs added this to Inbox in Porter and Mixins [OLD] via automation Nov 11, 2019
@carolynvs carolynvs changed the title Re-enable overriding dependency parameters from the manifest Re-enable defaulting dependency parameters from the manifest Nov 11, 2019
@squillace
Copy link

What does it mean to "default dependency parameters" here? If you had the dependent manifest, you'd know what params are possible, but are we saying that we do not know what the "defaults" are for those params? or that we have access to them at all? In the sense of being able to inject them from the subordinate bundle invocation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants