-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl/Cmd+Enter not working with date parameters #4025
Comments
Looks like the calendar hijacks the keyboard, so ctrl+ent closes it then another applies. |
Oh I think it's just a matter of disabling the need for "ok" click as now it's not needed. |
The behavior seems a bit different with me, am I missing something?
@ranbena for the React version it's basically the same, with the difference that I tested when the Calendar was closed, when it's open "the calendar hijacks the keyboard" seems to happen. The same doesn't happen in #4006. |
It is indeed not working when you select a Dynamic value to it, but in this case seems to be a matter of giving focus to the parameter after the selection. |
That's right.
Also right. Still, the calendar opens up on apply with ctrl+enter. |
It doesn't on the React version 😝. I'll start by working on the focus on the Date Picker and then we see where we can get :) |
I meant this: "(Ctrl+enter applies the value and opens the calendar again as enter key press event is passed to Antd DatePicker)" |
Me too, |
Not so related to the issue, #4033 will improve a little bit the behavior when you select dynamic values. Despite that, as I mentioned in the PR, Antd doesn't support key events in I believe it's possible to workaround that by forcing the focus to be somewhere else when the Calendar is closed, but I don't think it's worth it. |
Steps to Reproduce
Expected: it would apply changes.
Actual: nothing happens. 😢
Technical details:
The text was updated successfully, but these errors were encountered: