SAML_LOGIN_ENABLED behavior reflect correct state if SAML details are provided through env variables.

[johnny-zhong-nextroll]

Issue Summary

SAML login button disabled when 1 set of SAML login details are provided. This seems to be incorrect due to needing only 1 set. In fact, the options for SAML are radio, indicating that only 1 set is necessary for SAML to work.

Steps to Reproduce

1. Use environment variables to set up SAML. Only provide SAML_METADATA_URL, SAML_ENTITY_ID, SAML_NAMEID_FORMAT
2. See that the saml login button is not present.

This is a bug because for SAML login to function, we do not require both SAML_SSO_URL and SAML_METADATA_URL to be present. Only 1 needs to be provided with the proper SAML_LOGIN_TYPE.

Technical details:

• Redash Version: 10.1.0
• Browser/OS: n/a
• How did you install Redash: self-hosted

[ism-k]

Perhaps a future release with a bug fix in this pull-request will resolve your issue:
#5784

[arikfr]

This is not related to the issue, but I assume that the issue author or followers might have SAML enabled for their deployment and should be aware of the following Security Advisory: #5961. This affects all Redash versions and should be patched immediately.