Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for different ISSUE_TEMPLATE situations #26

Closed
6 tasks done
chadwhitacre opened this issue Jan 27, 2021 · 3 comments · Fixed by #35
Closed
6 tasks done

Account for different ISSUE_TEMPLATE situations #26

chadwhitacre opened this issue Jan 27, 2021 · 3 comments · Fixed by #35

Comments

@chadwhitacre
Copy link
Member

chadwhitacre commented Jan 27, 2021

@chadwhitacre
Copy link
Member Author

When run in a test:

  2021-01-28T16:43:39.4331449Z pass
  2021-01-28T16:43:39.4351926Z 
  2021-01-28T16:43:39.4359178Z pass
  2021-01-28T16:43:39.4373320Z foo
  2021-01-28T16:43:39.4381543Z pass
  2021-01-28T16:43:39.4402564Z pass
  2021-01-28T16:43:39.4418908Z fail

When run directly:

pass

pass
foo
pass
pass
pass

@chadwhitacre
Copy link
Member Author

Same shell.

/bin/bash
GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
fail
Run echo "$SHELL"
/bin/bash
GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
pass

@chadwhitacre
Copy link
Member Author

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

Default is sh -e {0}, shell: bash results in bash --noprofile --norc -eo pipefail {0}.

The pipefail explains the early termination in the shell: bash case when grep finds no match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant