Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach bots to react more immediately #5

Closed
chadwhitacre opened this issue Jan 6, 2021 · 4 comments
Closed

Teach bots to react more immediately #5

chadwhitacre opened this issue Jan 6, 2021 · 4 comments

Comments

@chadwhitacre
Copy link
Member

From @jan-auer in DM:

I quite dislike the lag that GH actions come with for bots. A few examples:

  • Our danger actions come with 20-30s delay of editing PR descriptions.
  • The new stale bot doesn't immediately remove the label once there's activity (at least I haven't seen it do that).

Suggested solution is Probot.

@jan-auer
Copy link
Member

jan-auer commented Jan 6, 2021

To add to this: Even if we trigger the stale bot on issue activity, but that would still incur whatever lag the actions come with. it sounds like a small thing, but 10s is enough for people to navigate away and no longer see the interaction.

In the past, I have made good experience with Probot. Configuration would still be stored per-repo in .github or here in getsentry/.github. We used to run our own probot, and it was migrated to GCP in 2019 IIRC. I'm not sure if it's still operating there.

A stale bot can be implemented via https://github.com/probot/stale.

@chadwhitacre
Copy link
Member Author

Turns out we already have https://github.com/getsentry/sentry-ci-tooling (private) which would be able to do this. It doesn't use probot, but it is a web app designed to handle GitHub webhooks.

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@chadwhitacre
Copy link
Member Author

Calling this done with initial implementations on eng-pipes, more to come over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants