generated from getsentry/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA actions are uploading source maps with dist="null" (string) #140
Comments
This was referenced Apr 20, 2023
Warning from #141 still pops up when using "getsentry/action-release@v1.4.1" : / |
I confirm:
I couldn't test whether the source map processing work without dist yet, but I imagine it does given it used to when it was none with the CLI. |
@florian-heer @MaximeLaurenty thank you for confirming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent change to support setting distribution (dist) in GHA actions introduced a couple of issues:
If the set value is null, the file will be uploaded with the string "null" as distribution, and if an event does not have a distribution set the source map processing that relies on perfect matching release+dist will not work.
as reported in Normalize the behaviour with
dist
#138, setting distribution is now required when uploading source maps. This is an optional value and should not be marked as required.The text was updated successfully, but these errors were encountered: