Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA actions are uploading source maps with dist="null" (string) #140

Closed
rodolfoBee opened this issue Apr 13, 2023 · 4 comments · Fixed by #148
Closed

GHA actions are uploading source maps with dist="null" (string) #140

rodolfoBee opened this issue Apr 13, 2023 · 4 comments · Fixed by #148
Assignees

Comments

@rodolfoBee
Copy link
Member

rodolfoBee commented Apr 13, 2023

The recent change to support setting distribution (dist) in GHA actions introduced a couple of issues:

  • If the set value is null, the file will be uploaded with the string "null" as distribution, and if an event does not have a distribution set the source map processing that relies on perfect matching release+dist will not work.

  • as reported in Normalize the behaviour with dist #138, setting distribution is now required when uploading source maps. This is an optional value and should not be marked as required.

@florian-heer
Copy link

florian-heer commented Apr 20, 2023

Warning from #141 still pops up when using "getsentry/action-release@v1.4.1" : /

@florian-heer
Copy link

florian-heer commented Apr 20, 2023

I'm sorry @armenzg ! I deployed the wrong version of my project which still used v1.3.1

I now can confirm that the warning from #141 is gone when using v1.4.1!

Thank you : )

@MaximeLaurenty
Copy link

MaximeLaurenty commented Apr 21, 2023

I confirm:

  • there is no more warning for me as well
  • without providing dist, the action works and it is set to none (not null).

I couldn't test whether the source map processing work without dist yet, but I imagine it does given it used to when it was none with the CLI.
Thanks!

@armenzg
Copy link
Member

armenzg commented Apr 21, 2023

@florian-heer @MaximeLaurenty thank you for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants