Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version collision with @sentry/profiling-node and other Sentry packages #195

Closed
cietho opened this issue Sep 4, 2023 · 5 comments
Closed

Comments

@cietho
Copy link

cietho commented Sep 4, 2023

When updating @sentry/profiling-node to the latest version via Renovate, we noticed that it uses a different versioning style for its dependencies. More specifically, it uses the SemVer range specifier (^), e.g. ^7.66.0. This is in contrast to other @sentry packages which pin their dependencies, e.g. 7.66.0. And that seems to lead to TypeScript errors when building.

Environment

  • Local environment running the current Node LTS

Logs

Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.
Type 'ProfilingIntegration' is not assignable to type 'Integration'.

Suggested Solution
The versioning for @sentry/profiling-node could match the other @sentry packages by pinning its dependencies. This change would help avoid TypeScript errors and make sure all packages work well together.

@kevin-riou-technis
Copy link

I totally agree, it could be very nice

@JonasBa
Copy link
Member

JonasBa commented Sep 5, 2023

I will pin these, but the real change will be for us to move this repo over to sentry-javascript so we can more seemingly keep up with the updates.

@mydea
Copy link
Member

mydea commented Sep 7, 2023

IMHO not sure if pinning this will actually help, as that just means you have to keep your node-profiling and core sentry packages versions in sync, just leading to potentially other issues? I think ^ is better, then in the host app you can still update your core Sentry package (you just need to make sure to dedupe your dependencies)...?

@dargmuesli
Copy link

This package is now part of sentry-javascript, right, @JonasBa? Therefore this issue can be marked as resolved, I think.

@JonasBa
Copy link
Member

JonasBa commented May 16, 2024

@dargmuesli correct, let me close this. Thank you for noticing this!

@JonasBa JonasBa closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants