OSGi compatibility

[alexandrul]

Is it possible to add the OSGi compatibility?

For an internal app I was able to use https://github.com/logstash/logstash-logback-encoder without any issues, but for raven-logback all my attempts of wrapping it are ending with:

Could not create an Appender of type [com.getsentry.raven.logback.SentryAppender]
ch.qos.logback.core.util.DynamicClassLoadingException: Failed to instantiate type com.getsentry.raven.logback.SentryAppender
java.lang.ClassNotFoundException: com.getsentry.raven.logback.SentryAppender cannot be found by ch.qos.logback.classic_1.2.2

[bretthoerner]

Hey @alexandrul, you're the first person to ask for this and I'm pretty unfamiliar with OSGi. Do you know much about it? Can you identify any of the ways that sentry-raven needs to change?

[alexandrul]

I have no idea, just that our app needs it.

This section from logstash-logback-encoder's pom.xml seems to specify some mandatory details:

https://github.com/logstash/logstash-logback-encoder/blob/master/pom.xml

<configuration>
	<instructions>
		<!-- packages to export -->
		<Export-Package>net.logstash.logback.encoder,net.logstash.logback.appender</Export-Package>
		<!-- attach to Logback bundle as fragment -->
		<Fragment-Host>ch.qos.logback.classic</Fragment-Host>
		<!-- exclude following imports as required classes are relocated by shade plugin and ignore ch.qos.logback.[core,classic] because this is a fragment and gets them from parent. -->
		<Import-Package>!org.apache.commons.*,!com.lmax.disruptor.*,!ch.qos.logback.classic.*,!ch.qos.logback.core.*,!org.slf4j.*,*</Import-Package>
	</instructions>
</configuration>

[bretthoerner]

Thanks, can you tell me what application server or framework (or something else?) you are using so that I can try to test this stuff out for myself? I'm pretty clueless here. 😄

[alexandrul]

I'm using an internal application that in turn uses an internal application container with some roots in Karaf (I think).
I just hope that someone else will encounter the same issue and it will be able to provide much more details.

For error aggregation I have started with logstash-logback-encoder, which required only two things:

1. copy the jar in the proper folder
2. update the logback.xml configuration

For sentry-java I was able to find a workaround by using a wrapper that makes it a logback fragment, this operation being required for every new release.

OSGi compatibility would make it a lot easier to use, in my particular case.

[maciejwalkowiak]

While this issue has been solved in 1.7, we currently do not support OSGI in 3.x.

[bruno-garcia]

Since this was raised over 3 years ago, I wonder what's the priority today.

[alexandrul]

@bruno-garcia If there aren't at least "n" requests for it, I guess you can just ignore it (where "n" is chosen by you based on the popularity of the other enhancements).

[romtsn]

We're gonna close this as there was not activity for 2 years. Please feel free to reopen if there's still a demand.

[talios]

I still use it daily from OSGi - basically we're just wrapping sentry and wiring it up to the OSGi LogService.

But it would be good to have the imports/exports back again at a minimum.