Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Raven.noConflict() when exporting as AMD module #109

Merged
merged 1 commit into from May 18, 2013

Conversation

ThisIsMissEm
Copy link

This cleans up the global namespace a bit.

@mattrobenolt
Copy link
Contributor

What's the issue this is trying to solve? I based my implementation on jQuery. Not that it's the best example, but I was just following suit. :)

See: https://github.com/jquery/jquery/blob/master/src/exports.js

@mattrobenolt
Copy link
Contributor

I also have plans for plugins, and not having a global Raven will mess them up. Not sure how to solve this, so I'm hesitant without thinking it fully through.

@mattrobenolt
Copy link
Contributor

Eh, I'll deal with it later. I have some ideas.

mattrobenolt added a commit that referenced this pull request May 18, 2013
Use Raven.noConflict() when exporting as AMD module
@mattrobenolt mattrobenolt merged commit cfb3e61 into getsentry:master May 18, 2013
@ThisIsMissEm
Copy link
Author

I think it'd still be possible to have an plugin architecture. You just need to make sure that they can register with Raven... We actually have stuff that we do with raven which is pretty much a plugin, or maybe more a wrapper to give us certain functionality.

@ThisIsMissEm
Copy link
Author

The main thing that this addresses is the fact that an AMD module shouldn't change the environment when it is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants