Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionController::UnknownFormat to ignore exceptions #761

Closed
wants to merge 2 commits into from
Closed

Add ActionController::UnknownFormat to ignore exceptions #761

wants to merge 2 commits into from

Conversation

iguchi1124
Copy link

@iguchi1124 iguchi1124 commented Sep 11, 2017

ActionController::UnknownFormat is rescued 406 http response from rails 5.

rails/rails#20666

so, I added this exception to default ignore exceptions. what do you think? @nateberkopec

@nateberkopec
Copy link
Contributor

Hmmm... sometimes I like receiving these because they're usually bad bots that I want to block. I guess I'm not sure.

@iguchi1124
Copy link
Author

I don't want to notify this error because this is not a server error.
It has better to make configure in the application's Rave.config.excluded_exceptions if someone want to notify this error for security reasons.

I think this proposal is same as ignoring ActionController::InvalidAuthenticityToken. 💭

@nateberkopec
Copy link
Contributor

Closing in favor of #769, but thanks for opening (otherwise wouldn't have had the idea!)

@iguchi1124
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants