Skip ActiveJob integration if there is a better one #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `already_supported_by_specific_integration?` returns true, the context and breadcrumbs are cleared by `capture_and_reraise_with_sentry`. This is wrong, because then the specific integration will report the exception with an empty context. Bypass the problem by not doing the `capture_and_reraise_with_sentry` if we have a specific integration
|
I am very interested in this pull request because we also see that no custom context is sent for delayed job exceptions. What is missing for the pull request to be merged? Is there something we can help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
already_supported_by_specific_integration?returns true, the context and breadcrumbs are cleared bycapture_and_reraise_with_sentry. This is wrong, because then the specific integration will report the exception with an empty context.Bypass the problem by not doing the
capture_and_reraise_with_sentryif we have a specific integration