Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply default scurbbing to span and breadcrumb data #1855

Closed
2 tasks done
cleptric opened this issue Feb 15, 2023 · 1 comment
Closed
2 tasks done

Apply default scurbbing to span and breadcrumb data #1855

cleptric opened this issue Feb 15, 2023 · 1 comment
Assignees
@iker-barriocanal
Labels
maintenance Tasks with this label generally have a lower priority and due date

Comments

@cleptric
Copy link
Member

cleptric commented Feb 15, 2023 •
edited by iker-barriocanal
Loading

We started to ship updates in the PHP SDKs and will ship Python/Ruby soon, where we removed sensitive data from http.client span descriptions and moved them into the span data instead.

This was decided in this RFC.
#1593 reverted this behavior, as the scrubbing of the span description introduced a regression.

We would now need to scrub the values of span.data.http.query and span.data.http.fragment as well as breadcrumb.data.http.query and breadcrumb.data.http.fragment by default in Relay.

Tasks
Beta Give feedback
  1. feat(pii-scrubbing): PII scrub span.data by default #1953
    iker-barriocanal
  2. test(scrubbing): Add tests for PII scrubbing in breadcrumb.data #1955
    iker-barriocanal
@cleptric
Copy link
Member Author

Related to getsentry/team-webplatform-meta#2

@jan-auer jan-auer added this to the Maintenance milestone Feb 20, 2023
This was referenced Feb 28, 2023
Merged
Closed
@iker-barriocanal iker-barriocanal mentioned this issue Mar 9, 2023
Closed
This was referenced Mar 20, 2023
Merged
Merged
@jernejstrasner jernejstrasner added the maintenance Tasks with this label generally have a lower priority and due date label Mar 23, 2023
@jernejstrasner jernejstrasner removed this from the Maintenance milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iker-barriocanal iker-barriocanal

Labels
maintenance Tasks with this label generally have a lower priority and due date
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jernejstrasner @jan-auer @cleptric @iker-barriocanal