Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Negative Outcomes: Denied Metrics #3482

Closed
Tracked by #3147
jan-auer opened this issue Apr 25, 2024 · 0 comments · Fixed by #3508
Closed
Tracked by #3147

Emit Negative Outcomes: Denied Metrics #3482

jan-auer opened this issue Apr 25, 2024 · 0 comments · Fixed by #3508
Assignees

Comments

@jan-auer
Copy link
Member

jan-auer commented Apr 25, 2024

Emit metric stats and outcomes for metrics that are dropped as a result of the config.metrics.denied_names config in Project::filter_metrics

Acceptance Criteria

  • Outcomes and metric stats should be emitted in a batched fashion wherever possible.
  • Outcomes should use DataCategory::MetricBucket and Outcome::Filtered with reason code "denied_name".
  • The volume metric stats (c:metric_stats/volume@none) should be emitted with the correct tagging and with OutcomeId::FILTERED.

Validation

  • Organization stats show the number of "Filtered Metrics" after sending metrics that have a denied name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants