Github Integration Broken

[geofferyj]

Self-Hosted Version

24.5.1

CPU Architecture

x86_64

Docker Version

26.1.3

Docker Compose Version

2.27.0

Steps to Reproduce

follow the instructions to add github integration from here

Expected Result

after following the instructions, I expect that on the integrations page, when I click on add integration it should begin the integration flow

Actual Result

after setting all the configurations,
re-running ./install.sh

in the integrations page, when Add Installation button is clicked, it just redirects me to the home page of my self hosted sentry. and I can't login again as the login page is missing.

Screen.Recording.2024-06-07.at.04.28.38.mov

Screen.Recording.2024-06-07.at.04.32.18.mov

Please take a look at the videos above.

Event ID

No response

[aldy505]

Hello, the GitHub integration is not broken. The docs is just misleading for now. There is a PR waiting to be merged here: https://github.com/getsentry/develop/pull/1235/files -- you should follow that one, add that additional config. I've pinged the related codeowners yet I don't get any response either, so we'll have to make do for now.

[geofferyj]

I don't know if I am doing something wrong but the integration still didn't work, SSO works now though.

when registration is enabled, signin with email and password is unavailable
I thought the integration flow will be the same as hosted sentry, clicking on add integration just takes you to the github app then back. please refer to the video below (PS. No detrimental info in the video)

Screen.Recording.2024-06-10.at.11.07.47.mov

[hubertdeng123]

I've taken a look at the docs PR up above. The integration flow is not the same as SaaS Sentry here, have you confirmed that you have set the appropriate callback urls?

[geofferyj]

yes I have confirmed that the URLs are correct.

[hubertdeng123]

Based on the behavior, it seems like perhaps there may be an error there somewhere, since it is redirecting you back without completing installation. What is the url you are being redirected to after clicking install and authorize?

[geofferyj]

it takes me back to home

here are the relevant URLs configured

public link: https://github.com/apps/penilabs-monitoring
home-url:https://monitoring.penilabs.com

callback URLs: - https://monitoring.penilabs.com/auth/sso/
- https://monitoring.penilabs.com/extensions/github/setup/

webhook-url: https://monitoring.penilabs.com/extensions/github/webhook/

Update: if I remove https://monitoring.penilabs.com/auth/sso/, integration works but sso stops working
then I add it back and everything seems to be working how

does the order of the callbacks matter?

[azaslavsky]

Update: if I remove https://monitoring.penilabs.com/auth/sso/, integration works but sso stops working
then I add it back and everything seems to be working how

So it works when you reverse the order of the callback URLs? I do not believe order should matter, but I am also not super well-versed in the specifics of this extension or the GitHub API.