Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaInfStripTransform issue with signed jars #309

Closed
romtsn opened this issue Apr 25, 2022 · 3 comments · Fixed by #334
Closed

MetaInfStripTransform issue with signed jars #309

romtsn opened this issue Apr 25, 2022 · 3 comments · Fixed by #334
Assignees
Labels
bug Something isn't working Platform: Android

Comments

@romtsn
Copy link
Member

romtsn commented Apr 25, 2022

The MetaInfStripTransform should also clean up the MANIFEST.MF file for transformed jars, if they are signed, because it contains references to stripped out files.

This only affects AGP versions between 7.0.0 and 7.1.2 where we run the transform.

@romtsn romtsn added bug Something isn't working Platform: Android labels Apr 25, 2022
@malbanese
Copy link

If interested, here's a sample project I put together that exhibits the issue mentioned in the other thread. The error can be encountered by running any of the test gradle tasks.

https://github.com/malbanese/sentry-gradle-3-0-1-test-execution-bug

@bruno-garcia
Copy link
Member

7.0.0: Dec 1, 2020
7.1.2 (February 2022)

Basically 1 year worth of AGP. But the solution is telling users to upgrade AGP

Ideas:

  • Create a troubleshoot page entry describing this and linking to this issue
  • SAGP check for the version and warns on the terminal users should upgrade AGP
  • Proper fix: Clean up manifest

@lbloder
Copy link
Collaborator

lbloder commented Jun 22, 2022

We decided to not transform signed Multi-Release jars and print a warning to inform the user that this might lead to issues which could be solved by upgrading to AGP > 7.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Platform: Android
Projects
Archived in project
4 participants