Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear in installation docs that the sibling SDK version has to match. #45

Closed
jennmueng opened this issue Jun 3, 2021 · 3 comments · Fixed by #248
Closed

Make clear in installation docs that the sibling SDK version has to match. #45

jennmueng opened this issue Jun 3, 2021 · 3 comments · Fixed by #248
Assignees
Labels
documentation Improvements or additions to documentation Platform: Capacitor update-sentry-js-sdk

Comments

@jennmueng
Copy link
Member

We will need to document in the installation steps to ensure the version of the sibling SDK matches the version of the sentry-javascript dependencies that @sentry/capacitor depends on.

@bruno-garcia
Copy link
Member

Is this something we can verify at build time to warn the user if it's wrong? Documenting is a must, I'm just trying to think of tools we can have to help users go through the:

  • Doesn't work, what's wrong?
  • Let me go through the docs see if I find anything, or; raise an issue on GitHub or support

@bruno-garcia bruno-garcia added the documentation Improvements or additions to documentation label Jan 11, 2022
@lucas-zimerman
Copy link
Collaborator

@bruno-garcia Ideally, We'd need to release a new version of Sentry Capacitor for every release of Sentry Javascript to avoid issues like that

@lucas-zimerman
Copy link
Collaborator

It seems like the version dependency is being respected if installed using npm, but not with yarn (it'll always install the latest version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Platform: Capacitor update-sentry-js-sdk
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants