Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Bug] Early exceptions are not send to sentry and deleted on the app restart #1488

Closed
2 of 5 tasks
ppeszko opened this issue Jan 25, 2019 · 5 comments
Closed
2 of 5 tasks

Comments

@ppeszko
Copy link

ppeszko commented Jan 25, 2019

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

v11.3.0
6.4.1
ReactNativeSentryMissingExceptionsProject@0.0.1 /Users/projects/ReactNativeSentryMissingExceptionsProject
├── react@16.6.1
├── react-native@0.57.7
└── react-native-sentry@0.40.2

Config:

Sentry.config('https://51e610c7477a4363af4ccfd9517e0bdb@sentry.io/1352206').install();

I have following issue:

If an app throws an exception really early in the lifecycle (https://github.com/ppeszko/ReactNativeSentryMissingExceptionsProject/blob/master/App.js#L27) this exception will be never reported to the sentry backend. The exception will be recorded, and you can confirm it by downloading the app bundle:

screenshot 2019-01-25 at 13 28 59

But on the app restart the exception will be deleted/rejected by the following code:

https://github.com/getsentry/react-native-sentry/blob/master/ios/RNSentry.m#L140

The comment in the above line is a well a bit confusing as it would suggest that the exception was handled ('we sent it already before the app crashed') but in fact, it wasn't.

Our question is:

  • is this something which is a known issue and won't be addressed?
  • is there a way to be able to see all exceptions in sentry?

Steps to reproduce:

Expected result:

  • All exceptions are reported to sentry backend so they can be fixed
@HazAT
Copy link
Member

HazAT commented Feb 11, 2019

Thanks for the repro case, this is actually a bug I would say.
Not sure when we are able to fix it though but we are aware of it now.

@HazAT HazAT assigned HazAT and unassigned HazAT Feb 11, 2019
@ppeszko
Copy link
Author

ppeszko commented Feb 12, 2019

thank you checking it @HazAT 🙇 :)

@marandaneto
Copy link
Contributor

still happens on the latest Sentry RN version, since the App crashes immediately, the iOS SDK doesn't have time to send it, only on iOS tho.

@marandaneto marandaneto transferred this issue from getsentry/sentry-react-native Nov 26, 2021
@marandaneto
Copy link
Contributor

since this is an issue with the iOS SDK only and requires more discussion on how to tackle this, I've transferred to the iOS repo, we'll follow up on this.

@philipphofmann
Copy link
Member

Is a duplicate of #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants