Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release versioning. #306

Closed
lucas-zimerman opened this issue Mar 8, 2023 · 1 comment · Fixed by #310
Closed

Fix release versioning. #306

lucas-zimerman opened this issue Mar 8, 2023 · 1 comment · Fixed by #310

Comments

@lucas-zimerman
Copy link
Collaborator

  files: ['./src/ios/SentryCordova.m'

No longer contains the version on the iOS version on the file (SentryCordovaVersionString) since 2021
https://github.com/getsentry/sentry-cordova/pull/204/files#diff-f8a47e25919a891e528e41e9ef8d5d529c792f32c9649b42159bc02db15e76b2L4

Current Regex for updating the version of package.xml is broken and is not updating the release version ( a simple fix like

id="sentry-cordova" version="\d+\.\d+.\d+.+">

should fix it).

ADDITIONALLY, There should be at least an action to validate that those files that are expected to have a release version defined in code have the correct version defined.

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant