Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting commit #19

Closed
danilofuchs opened this issue Dec 10, 2021 · 6 comments · Fixed by #62
Closed

Support for setting commit #19

danilofuchs opened this issue Dec 10, 2021 · 6 comments · Fixed by #62
Labels
help wanted Extra attention is needed Platform: Dart

Comments

@danilofuchs
Copy link

danilofuchs commented Dec 10, 2021

Release tracking gets even better with Commit Hash info when the GitHub source repo is integrated with Sentry.

The sentry releases set-commits command would be useful if integrated

@marandaneto
Copy link
Contributor

@danilofuchs indeed, would you like to contribute with a PR? this plugin was a fun hack week project, we don't have anyone working on it actively (other than bug fixing), but happy to guide contributors :)

@marandaneto marandaneto added the help wanted Extra attention is needed label Dec 11, 2021
@marandaneto
Copy link
Contributor

Consider adding support for React native as well, I will create an issue for it.

@marandaneto
Copy link
Contributor

marandaneto commented Oct 7, 2022

@vaind would you like to give it a stab at #43 ?
Meta issue getsentry/team-mobile#33
Example using --auto https://github.com/sentry-demos/android/blob/8c9d690293d3ebe76e760bfb0718da883885ebd6/Makefile#L10-L18
Sentry CLI docs https://docs.sentry.io/product/cli/releases/#sentry-cli-commit-integration

I believe that the plugin should offer an auto configuration, if it is disabled and a commit is specified, use the specified commit.
Maybe using --ignore-missing by default as well https://docs.sentry.io/product/cli/releases/#dealing-with-missing-commits

@vaind
Copy link
Collaborator

vaind commented Oct 7, 2022

@vaind would you like to give it a stab at #43 ? Meta issue [getsentry/team-mobile#33]

yes, that's actually the issue that brought me here, but I had to do some yak shaving first so that I could be confident my changes won't break other things.

@marandaneto
Copy link
Contributor

@vaind wondering if this should be considered:

Maybe using --ignore-missing by default as well https://docs.sentry.io/product/cli/releases/#dealing-with-missing-commits

Since you've not replied nor implemented, was there a reason to not do this by default?
It's not super important, just trying to narrow down the problem here.

@vaind
Copy link
Collaborator

vaind commented Nov 2, 2022

Right, I guess I've forgotten to reply here. I guess the same question has already been considered elsewhere and the decision was to make it an opt-in in the CLI. I think It would be good to check with the original developers who may have had good reasons to do so - potential issues we're not even considering here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Platform: Dart
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants