Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages as in app excludes #729

Open
ueman opened this issue Jan 31, 2022 · 3 comments
Open

Add packages as in app excludes #729

ueman opened this issue Jan 31, 2022 · 3 comments

Comments

@ueman
Copy link
Collaborator

ueman commented Jan 31, 2022

The Flutter event enricher already supports reading used packages and adding those to an event. This information can be used to mark frames as in app excludes.

Please note, that reading packages is an expensive (as in could take a second or two) operation and should therefore not delay the app start.

@marandaneto marandaneto added this to To do in kanban via automation Jan 31, 2022
@marandaneto marandaneto removed this from To do in kanban Jan 31, 2022
@marandaneto
Copy link
Contributor

That would be done only once tho, if reportPackages is enabled, sounds like something that would improve grouping.
Do you experience bad grouping or is it something that just came up in your mind?

@ueman
Copy link
Collaborator Author

ueman commented Jan 31, 2022

I'm currently using the approach of adding the app package name as in app include and addInAppByDefault = false approach, but based on the packages it could probably done without any manual configuration. So it would be a nice enhancement.

@marandaneto
Copy link
Contributor

A downside of this is when apps are obfuscated (Web is minified), or AOT via https://docs.flutter.dev/deployment/obfuscate
The inApp detection is always setting all the frames to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants