Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom instrumentation to collect slow and frozen frames #789

Closed
Tracked by #14
ueman opened this issue Mar 18, 2022 · 3 comments · Fixed by #1011
Closed
Tracked by #14

Allow custom instrumentation to collect slow and frozen frames #789

ueman opened this issue Mar 18, 2022 · 3 comments · Fixed by #1011

Comments

@ueman
Copy link
Collaborator

ueman commented Mar 18, 2022

I would like to be able to use the frames integration on macOS. Currently that's not possible because it depends on native code, which is also not able to provide frame information.

However I could gather frame informations in pure Flutter code, based on #699 . That would also enable that feature on Linux and Windows and it's compatible from Flutter 2.0 onwards.

Therefore, I would like to have a way to somehow achieve this.

@marandaneto
Copy link
Contributor

@ueman we're experimenting with a new public API for adding custom measurements, See getsentry/sentry-python#1359
Not sure if we will make SentryNative flexible enough, but rather give you a proper way to report any measurement based on your own way.

@ueman
Copy link
Collaborator Author

ueman commented Mar 23, 2022

Yeah, but then I would also have to write my own NavigationObserver and so on. The support for custom metrics is pretty exciting.

@philipphofmann philipphofmann changed the title Make SentryNative configurable Allow custom instrumentations to collect slow and frozen frames May 19, 2022
@philipphofmann philipphofmann changed the title Allow custom instrumentations to collect slow and frozen frames Allow custom instrumentation to collect slow and frozen frames May 19, 2022
@philipphofmann
Copy link
Member

We will make an abstraction in the API that when you use the custom instrumentation, slow and frozen frames are attached automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants