-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for NNBD #99
Comments
@rxlabz would be great to add null safety as early as possible. Since retrofitting it is much harder than adding code while having it turned on. @marandaneto ? |
yep I'd love to turn it on as well but we'd need to see how much work is to fix all the 200 errors. |
The number is high because of the json encoding/decoding, it makes a lot of potentially null values. Should not be very long/hard to fix. Anyway, I think the Dart team talked about releasing a tool to help the migration. Next week I'll check if something is already available. |
@rxlabz worth noting that from Sentry's perspective |
Thanks, I'll keep that in mind ! |
NNBD is not Flutter ready and we are blocked by it, let's revisit this at a later time. |
Flutter now recommends migration for packages and has a migration tool for assistance: https://dart.dev/null-safety/migration-guide |
@MisterJimson true, I've been watching this tool, the thing is, supporting null safety right now would require to bump the min. Dart and Flutter SDK versions and not everyone is comfortable using beta versions right. See: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king Ideally, we'd do that using a branch, so we could publish a Prerelease with the null-safety feature, but still supporting older versions. |
A |
Absolutely I would expect null safety as a pre release and not in the main line for a while, just as the migration docs suggest. |
We'll implement this as part of #247 |
For now the package has almost 200 errors with NNDB activated cf. https://dart.dev/null-safety
The text was updated successfully, but these errors were encountered: