Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Changelog] Add hash/anchor to url when clicking Categories/Dates/Search on the Changelog #9410

Closed
HazAT opened this issue Mar 11, 2024 · 4 comments
Labels
Product Area: Docs Type: Platform Issues about the platform & functionality of our docs

Comments

@HazAT
Copy link
Member

HazAT commented Mar 11, 2024

^ title

It's nice for sharing urls.

@vivianyentran vivianyentran added Type: Platform Issues about the platform & functionality of our docs Product Area: Docs labels Mar 11, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Mar 11, 2024

Routing to @getsentry/product-owners-docs for triage ⏲️

@a-hariti
Copy link
Collaborator

a hash makes sense for dates, but probably not for categories (more than one) or search,
maybe saving state to query params would be better? (but uglier) @HazAT

@Shubhdeep12
Copy link
Contributor

yes, ideally we should add params for both dates and categories(comma separated ids of categories) in the URL.

@HazAT
Copy link
Member Author

HazAT commented May 13, 2024

this is done

@HazAT HazAT closed this as completed May 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Product Area: Docs Type: Platform Issues about the platform & functionality of our docs
Projects
Status: Done
Archived in project
Archived in project
Development

No branches or pull requests

5 participants