Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 404 page #9656

Closed
mydea opened this issue Apr 10, 2024 · 4 comments · Fixed by #9428
Closed

Improve 404 page #9656

mydea opened this issue Apr 10, 2024 · 4 comments · Fixed by #9428
Assignees
Labels
Improvement Type: Platform Issues about the platform & functionality of our docs

Comments

@mydea
Copy link
Member

mydea commented Apr 10, 2024

Problem Statement

If you go to a page that does not exist, e.g.:
https://docs.sentry.io/platforms/javascript/DOES-NOT-EXIST

You get a very generic 404 page. It would be nice to show the 404 page in the context of the platform/guide that is in the URL - this makes it much easier to continue from a broken link.

Solution Brainstorm

Something like this(formatting is off, but you get the point hopefully xD)

image

@mydea mydea added Type: Platform Issues about the platform & functionality of our docs Improvement labels Apr 10, 2024
@Shubhdeep12
Copy link
Contributor

Shubhdeep12 commented Apr 12, 2024

Hi,

I have a way to do this. but I am not sure if that is an optimal way 😅

I'll raise a PR for this shortly.

here is the outcome of that -
image

@hubertdeng123
Copy link
Member

@mydea Do you have an idea who would be the best candidate to review the PR?

@mydea
Copy link
Member Author

mydea commented May 7, 2024

@stephanie-anderson is this solved in the new design? still seems somewhat the same to me: https://docs.sentry.io/platforms/javascript/asdasd/

@a-hariti
Copy link
Collaborator

a-hariti commented May 7, 2024

We couldn't add the described features due fundamental limitations of Next.js + our unique SSR needs

the current state seemed like a good compromise

You can follow my question on the Next.js discord here

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Type: Platform Issues about the platform & functionality of our docs
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants