Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatingSystem no longer from user agent #134

Closed
mrcarl79 opened this issue Nov 12, 2018 · 2 comments
Closed

OperatingSystem no longer from user agent #134

mrcarl79 opened this issue Nov 12, 2018 · 2 comments

Comments

@mrcarl79
Copy link

In the old client I'm sure that the OS was picked up and parsed from the user agent, however now it's just the OS of the server.

In Sentry.Protocol.OperatingSystem it says:

/// In web contexts, this is the operating system of the browser (normally pulled from the User-Agent string).

But in sentry-dotnet where it populates this context it takes the server OS.

Is this by design now? is there anyway to override this with the client OS from the user agent? temporarily I'm adding tags with this info but I preferred how it worked previously.

Thanks

@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 12, 2018

@mrcarl79 The docs are correct but at this point only Javascript events have the User-Agent parsing enabled. We have a issue open to get this fixed so that events from other platforms like .NET and PHP can also take advantage of it.

On SharpRaven the reported OS is of the machine running the .NET code, not the User-Agent. This is the same in this (new) .NET SDK. The difference here is that the ASP.NET Core integration reports the system OS and runtime as server-os and server-runtime and no icons are displayed at the top for those. User-Agent is correctly reported but at this point, as I mentioned above, it's not being parsed for .NET events.

Related to: getsentry/sentry#8555, getsentry/raven-csharp#261

@bruno-garcia
Copy link
Member

Since there's nothing to be done on this repo, I'll close this issue.

Please subscribe for changes to: getsentry/sentry#8555 as we'll be updating that one once the parsing is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants