Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete unnecessary APIs #1585

Closed
3 tasks done
mattjohnsonpint opened this issue Apr 21, 2022 · 5 comments
Closed
3 tasks done

Obsolete unnecessary APIs #1585

mattjohnsonpint opened this issue Apr 21, 2022 · 5 comments
Labels
Feature New feature or request
Milestone

Comments

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Apr 21, 2022

This issue will keep track of APIs that we want to remove in the next major release (4.0.0). Will keep this open and update as we find them. See https://github.com/getsentry/sentry-dotnet/blob/main/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt for list from the main Sentry project.

@bitsandfoxes
Copy link
Contributor

Does scope.Platform qualify? #1590

@mattjohnsonpint
Copy link
Contributor Author

Does scope.Platform qualify? #1590

Yes, I think so.

@mattjohnsonpint
Copy link
Contributor Author

Another - Contexts didn't need to inherit from ConcurrentDictionary<string, object>. It would be better to inherit from IDictionary<string, object> instead, and encapsulate it instead. See comments : #1332 (comment)

@bruno-garcia
Copy link
Member

Other good candidates: WIthScope API. It was reverted from being marked obsolete due to what I believe was a misunderstanding, since it's broken on global mode. And a new one with async was introduced, Another one worth considering making obsolete is the original; ConfigureScopeAsync, but this is less obvious:

That's because the SDK avoid calling callbacks if disabled as an optimization. While people put their core business logic inside our callbacks. So the async call can be spared if the sole reason to run it is to fetch data to set to the scope. But WithScope has logic that happens inside and folks expect to always run regardless of Sentry being configured.

Local scope works in global mode and local mode and is advised instead.

@jamescrosswell
Copy link
Collaborator

We now have separate issues for each of the items mentioned here and we already have the feat/4.0.0 pull request as an umbrella to sit across these (plus all the others)... so closing this issue as redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants