-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentryHttpFailedRequestHandler disposes Content on .net framework #2684
Comments
Hi @Liklainy, thanks for getting in touch. @bitsandfoxes we could fairly easily implement our own However, we've already got a workaround for the broken framework code, but at the moment that workaround only protects the proper functioning of our own code (but doesn't guarantee other stuff won't get broken). In this particular case, I'd be OK to bend the "don't copy framework code into our solution" rule, as long as our code is only used on .netcore3.1 and below. Under the hood, all
|
Hi @jamescrosswell, thank you for quick reply! I can suggest two ways to fix this issue:
|
I agree with this. |
Package
Sentry
.NET Flavor
.NET Framework
.NET Version
4.7.2
OS
Any (not platform specific)
SDK Version
3.33.0
Self-Hosted Sentry Version
No response
Steps to Reproduce
NSwag
HttpClient
withSentryHttpMessageHandler
and pass it to generated clientSentryHttpFailedRequestHandler
Expected Result
No exception thrown
Actual Result
EnsureSuccessStatusCode
which disposesContent
on older versions (before net core)200
it tries to read content body which is already disposed and generatesObjectDisposed
exceptionThe text was updated successfully, but these errors were encountered: