Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sourcelink data is available send with event #400

Closed
bruno-garcia opened this issue May 8, 2020 · 5 comments
Closed

When sourcelink data is available send with event #400

bruno-garcia opened this issue May 8, 2020 · 5 comments
Labels
Feature New feature or request Up-For-Grabs

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented May 8, 2020

There's a draft PR: #230

This post from Microsoft could be referred from our docs to suggest users to bundle pdbs in the assemblies. Also to suggest embedding sources, and read the source.

https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/

In Sentry it could link to the source code repository/commit.

Server-side could also fetch the actual source and render SourceContext.

@bruno-garcia bruno-garcia added the Feature New feature or request label May 8, 2020
@bruno-garcia
Copy link
Member Author

Related #230

@Lonli-Lokli
Copy link

Any update?

@bruno-garcia
Copy link
Member Author

@Lonli-Lokli none yet. Also, we'd need to change the server to fetch the source code.

@bruno-garcia
Copy link
Member Author

There was a initial work on this that didn't get completed but we'd love to see this feature land: #230

@SimonCropp
Copy link
Contributor

we will close this one since the larger issue #1740 tracks this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Up-For-Grabs
Projects
Archived in project
Development

No branches or pull requests

4 participants