Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CacheFlushTimeout to something more descriptive #638

Closed
bruno-garcia opened this issue Dec 3, 2020 · 3 comments · Fixed by #641
Closed

Rename CacheFlushTimeout to something more descriptive #638

bruno-garcia opened this issue Dec 3, 2020 · 3 comments · Fixed by #641
Labels
Feature New feature or request Up-For-Grabs

Comments

@bruno-garcia
Copy link
Member

sentry-dotnet/src/Sentry/SentryOptions.cs

Line 384 in 429c58b

public TimeSpan CacheFlushTimeout { get; set; } = TimeSpan.FromSeconds(1);

Ideally it should clarify that it: Blocks initializing the SDK if offline caching is enabled and events are on disk to be sent. Something like BlockInitForCacheFlushTimeout but ideally less horrible.

Which makes me realize, before using the field, make sure the CacheDir isn't null.
@bruno-garcia bruno-garcia added Feature New feature or request Up-For-Grabs labels Dec 3, 2020
@lucas-zimerman
Copy link
Collaborator

CacheFlushTimeout -> InitializeCacheTimeout ?

@bruno-garcia
Copy link
Member Author

Maybe Just InitCacheFlushTimeout

@lucas-zimerman
Copy link
Collaborator

mmm sounds good,

@lucas-zimerman lucas-zimerman mentioned this issue Dec 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Up-For-Grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: rename CacheFlushTimeout to InitCacheFlushTimeout. lucas-zimerman/sentry-dotnet
2 participants
@bruno-garcia @lucas-zimerman