-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation issue - advise that assembly names that start with "Sentry" won't have their logger entries logged #99
Comments
I'm sorry that wasted your time. Besides documenting this behavior, I'd also suggest we log a debug message. Thanks for raising this. |
Just wondering whether there's potentially another way forward.. Thinking out loud here. Is it true to say that any Sentry namespaces that could cause infinite loops are either within the Extensions.Logging project itself or a referenced assembly? If so, I'm just wondering whether you could say "it begins with Sentry and it's in this assembly or one of this assembly's references". |
An error could come from We could have this filter prefix configurable, with Sentry there by default. At least this is only an issue when creating test apps named 'SentryTest' or something. Perhaps a simple fix would be to simply changing to: namespace.StartsWith("Sentry.") || namespace == "Sentry" This could be a simpler change. |
@cpwood I was explicit about this behaviour in the docs now: |
For the Extenions.Logging implementation, it looks as though any assembly whose name starts with the word "Sentry" won't have their logged messages sent to sentry.io .
This cost me a few hours of frustration because I started a new project called "SentryLoggingTest" which logged nothing to sentry.io ! Took a lot of reading of source code to find out why!
I suggest the README.md file is updated to reflect this.
The text was updated successfully, but these errors were encountered: