Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sentry/utils stripSentryFramesAndReverse may no longer limit number of stack frames #653

Closed
timfish opened this issue Mar 13, 2023 · 1 comment · Fixed by #657
Closed

Comments

@timfish
Copy link
Collaborator

timfish commented Mar 13, 2023

Problem Statement

Once this PR is merged and released, limiting stack frames may move from stripSentryFramesAndReverse into createStackParser.

Solution Brainstorm

If this occurs, limiting the number of stack frames will need to be added here:

export const electronRendererStackParser: StackParser = (stack: string, skipFirst: number = 0): StackFrame[] => {
const frames: StackFrame[] = [];
for (const line of stack.split('\n').slice(skipFirst)) {
const chromeFrame = chrome(line);
const nodeFrame = node(line);
// We favour the chrome parser unless in_app == false
if (chromeFrame && nodeFrame?.in_app !== false) {
frames.push(chromeFrame);
} else if (nodeFrame) {
frames.push(dropUndefinedKeys(nodeFrame));
}
}
return stripSentryFramesAndReverse(frames);
};

@AbhiPrasad
Copy link
Member

Released with 7.44.0 https://github.com/getsentry/sentry-javascript/releases/tag/7.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants