Recover and RecoverWithContext with arbitrary types

[rhcarvalho]

Recover and RecoverWithContext send events to Sentry when they recover from panics and the recovered value has type error or string. Any other types are ignored.

sentry-go/client.go

Lines 233 to 284 in 550a179

	// Recover captures a panic.
	// Returns `EventID` if successfully, or `nil` if there's no error to recover from.
	func (client *Client) Recover(err interface{}, hint *EventHint, scope EventModifier) *EventID {
	if err == nil {
	err = recover()
	}
	if err != nil {
	if err, ok := err.(error); ok {
	event := client.eventFromException(err, LevelFatal)
	return client.CaptureEvent(event, hint, scope)
	}
	if err, ok := err.(string); ok {
	event := client.eventFromMessage(err, LevelFatal)
	return client.CaptureEvent(event, hint, scope)
	}
	}
	return nil
	}
	// Recover captures a panic and passes relevant context object.
	// Returns `EventID` if successfully, or `nil` if there's no error to recover from.
	func (client *Client) RecoverWithContext(
	ctx context.Context,
	err interface{},
	hint *EventHint,
	scope EventModifier,
	) *EventID {
	if err == nil {
	err = recover()
	}
	if err != nil {
	if hint.Context == nil && ctx != nil {
	hint.Context = ctx
	}
	if err, ok := err.(error); ok {
	event := client.eventFromException(err, LevelFatal)
	return client.CaptureEvent(event, hint, scope)
	}
	if err, ok := err.(string); ok {
	event := client.eventFromMessage(err, LevelFatal)
	return client.CaptureEvent(event, hint, scope)
	}
	}
	return nil
	}

We should send events no matter the type we're recovering (and need to handle the case in which the value is not serializable as JSON).

[trungdq88]

I'm glad that this is reported, I wasted 1 hour debugging why my panic(123) didn't work :(