New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add transactions to sync transport #243

Merged

rhcarvalho merged 1 commit into master from abhi/feat/sync-transport-transaction

Jun 4, 2020

Member

AbhiPrasad commented Jun 3, 2020

PR Addressing #235 (comment)

We previously merged in new Transaction interfaces, and support for using the envelopes endpoint, but we only updated the async transport.

This PR updates HTTPSyncTransport to use getRequestFromEvent.


          feat: Add transactions to sync transport

22423df

AbhiPrasad requested a review from rhcarvalho

June 3, 2020 23:02

rhcarvalho approved these changes

View reviewed changes

rhcarvalho merged commit 64cb84e into master

rhcarvalho deleted the abhi/feat/sync-transport-transaction branch

June 4, 2020 07:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment