feat: Add debug logging for release detection #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables anyone to understand better how the SDK decided to report a given Release value. Also: - Simplify code to use exec.Cmd.Output instead of exec.Cmd.Run with a manually created bytes.Buffer - Remove check of commit hash length returned from Git -- we can use any length for Release.
kamilogorek
previously approved these changes
Jul 19, 2021
AbhiPrasad
previously approved these changes
Jul 19, 2021
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
rhcarvalho
dismissed stale reviews from AbhiPrasad and kamilogorek
via
03a48e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables anyone to understand better how the SDK decided to report a
given Release value.
Also:
manually created bytes.Buffer
length for Release.