Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable stack trace offset when using abstracted interface #458

Open
mbrancato opened this issue Jul 8, 2022 · 1 comment
Open

Comments

@mbrancato
Copy link

Summary

It's very likely that as an application grows, developers will seek to abstract some foundational things they may need such as logging, etc. And additionally, manually capturing Sentry breadcrumbs or events would likely get abstracted as well. If an error has a stacktrace already, great. Otherwise, using sentry.NewStacktrack() is the way to go. But this hard-codes the offset to 1.

I'd like it if we can configure the offset in the pcs from runtime.Callers so that the trace starts where the problem was, and not in the logger or other abstraction.

Motivation

I already have a logger based on Zap and want to add Sentry integration. My logger is the first few frames of the stack trace which is clutter.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants