Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid transaction source: echo #588

Closed
jjbayer opened this issue Feb 24, 2023 · 2 comments · Fixed by #637
Closed

Invalid transaction source: echo #588

jjbayer opened this issue Feb 24, 2023 · 2 comments · Fixed by #637

Comments

@jjbayer
Copy link
Member

jjbayer commented Feb 24, 2023

Summary

Relay is reporting an invalid transaction source emitted by the Go SDK version 0.17.0. If this was fixed in >= 0.18.0, feel free to close this issue.

"sdk": {
    "name": "sentry.go",
    "version": "0.17.0",
    "integrations": [
        "ContextifyFrames",
        "Environment",
        "IgnoreErrors",
        "Modules"
    ],
    "packages": [
        {
            "name": "sentry-go",
            "version": "0.17.0"
        }
    ]
},
"transaction_info": {
    "source": "echo"
}

Steps To Reproduce

Go to https://sentry.my.sentry.io/organizations/sentry/issues/391873, and use the project tag to find example events in that project.

Expected Behavior

The SDK sends one of the transaction sources listed in
https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations.

SDK

See JSON snippet

Sentry

  • Using hosted Sentry in sentry.io? yes
@tonyo
Copy link
Member

tonyo commented Feb 24, 2023

Looks like we should add additional guards in places where we set transaction sources from external inputs, e.g.

@cleptric
Copy link
Member

We would also need to not export the Span.Source field then. Adding a getter/setter seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants