Added doc on how to handle logrus.Fatalf events #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaumanndev
approved these changes
Nov 17, 2022
flimzy
reviewed
Nov 18, 2022
cleptric
reviewed
Nov 28, 2022
|
@Mindstan Ping 🙂 |
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
…ry-go into logrus_example_fatal
cleptric
approved these changes
Dec 7, 2022
|
Thank you! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some doc on how to handle
logrus.Fatalfevents.When calling
logrus.Fatalf(),logruscallsos.Exit(1)immediately after treating the log. They are two consequences :deferare ignored;fatalevent to the remote server before the program stops.Fortunately,
logrus.RegisterExitHandlerallows to run arbitrary code before the call toos.Exit. I propose to add it to thelogrusexample.